Skip to content

fix: Fix version bump verification#30221

Merged
Cal-L merged 1 commit into
mainfrom
fix/version-bump
May 14, 2026
Merged

fix: Fix version bump verification#30221
Cal-L merged 1 commit into
mainfrom
fix/version-bump

Conversation

@Cal-L
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L commented May 14, 2026 •
edited by cursor Bot
Loading

Description

This relaxes the version bump script to verify both iOS and Android bumps upwards

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk shell-script change limited to build version validation; main impact is potentially blocking releases if either platform’s build number doesn’t strictly increase.

Overview
Updates scripts/set-build-version.sh to stop requiring Android and iOS build numbers to be in sync, and instead validates the provided VERSION_NUMBER is greater than each platform’s current value.

Improves logging by printing CURRENT_ANDROID_VERSION_NUMBER and CURRENT_IOS_VERSION_NUMBER, and routes version-regression failures through log_and_exit for consistent error handling.

Reviewed by Cursor Bugbot for commit 7f04caa. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2 metamaskbotv2 Bot added the team-mobile-platform Mobile Platform team label May 14, 2026
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels May 14, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue May 14, 2026
@Cal-L Cal-L enabled auto-merge May 14, 2026 23:20
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 14, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change is limited to scripts/set-build-version.sh, a build utility script used during the release/versioning process. The modification:

  1. Removes the strict requirement that Android and iOS version numbers must be in sync before proceeding (previously blocked if they differed).
  2. Replaces the single combined version check with two independent checks — one for Android and one for iOS — each using log_and_exit for consistent error handling.
  3. Improves logging to show platform-specific current version numbers.

This change has zero impact on:

  • App source code or runtime behavior
  • E2E test infrastructure or test files
  • Any controllers, components, or user flows
  • Navigation, confirmations, accounts, networks, or any other testable feature area

No E2E tests need to run for this change. It is purely a build tooling improvement that allows Android and iOS build numbers to diverge (useful when platforms are versioned independently) while still ensuring the new version number is strictly greater than the current one on each platform.

Performance Test Selection:
This is a build script change with no impact on app runtime performance, UI rendering, data loading, or any measurable performance characteristic. No performance tests are needed.

View GitHub Actions results

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue May 14, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 14, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Cal-L Cal-L added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit 2682c1c May 14, 2026
100 checks passed
@Cal-L Cal-L deleted the fix/version-bump branch May 14, 2026 23:57
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue May 14, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 14, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.79.0 Issue or pull request that will be included in release 7.79.0 label May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

@weitingsun weitingsun weitingsun approved these changes

Assignees

No one assigned

Labels

no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.79.0 Issue or pull request that will be included in release 7.79.0 size-S team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Cal-L @tommasini @weitingsun